Re: [PATCH v4 0/6] Config-related patches

Subject: Re: [PATCH v4 0/6] Config-related patches

Date: Sat, 14 Apr 2012 12:33:03 -0700

To: Mark Walters, Peter Wang, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sat, Apr 14 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Two minor comments which you might like to consider (but definitely are
> not required):
>     1) You could check that there are no further arguments when the user
>     calls `notmuch config list'

This doesn't seem so necessary to me.  I'm fine if it just silently
ignores extra arguments.

>     2) In the man page you could explicitly say what the output is for a
>     configuration item which has not been set.

I'm also fine with it as it is.  I think it's implied that if the value
is null then the field is left blank.  That's ok.

jamie.
part-000.sig (application/pgp-signature)

Thread: