Re: [PATCH 2/8] emacs: update tag-completion function

Subject: Re: [PATCH 2/8] emacs: update tag-completion function

Date: Mon, 09 Apr 2012 11:09:21 -0700

To: Mark Walters, Notmuch Mail

Cc:

From: Jameson Graef Rollins

On Mon, Apr 09 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>> -	      nil "search-tags" search-terms)))
>> +	      nil "search" "--output=tags" search-terms)))
>
> Perhaps make this 
>   + nil "search" "--output=tags" "--exclude=false" search-terms)))
>
> to fix the existing bug that if the message is excluded the completion
> can get confused. Or I can submit that separately if you prefer.

Hey, Mark.  Yes, that was included as a separate patch in v1 of the
series, but now that your exclude stuff has been pushed this should be
included as well.  I'll send a patch for this now.

jamie.

• Previous message (by thread): Re: emacs tagging cleanup, v3

Thread:

• Jameson Graef Rollins—improvements to some emacs search tagging functions [inbox, unread]
  • Jameson Graef Rollins—[PATCH 1/6] emacs: update tag-completion function [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Jameson Graef Rollins—[PATCH 2/6] emacs: have tag-completion return all tags for nil input [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 4/6] emacs: remove redundant notmuch-search-tag-thread function [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
          • Jameson Graef Rollins—[PATCH 5/6] emacs: change name of search-archive-thread function to just search-archive [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
            • Jameson Graef Rollins—[PATCH 6/6] emacs: include tags from excluded messages in tag tab completion [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument [inbox, notmuch::review, unread]
      • Dmitry Kurochkin—Re: [PATCH 2/6] emacs: have tag-completion return all tags for nil input [inbox, notmuch::review, unread]
  • Jameson Graef Rollins—Re: improvements to some emacs search tagging functions [inbox, signed, unread]
  • Jameson Graef Rollins—emacs tagging cleanup [inbox, unread]
    • Jameson Graef Rollins—[PATCH 1/8] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 2/8] emacs: update tag-completion function [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 3/8] emacs: have tag-completion return all tags for nil input [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 4/8] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Jameson Graef Rollins—[PATCH 6/8] emacs: eliminate search-tag-thread in favor of just search-tag [inbox, notmuch::obsolete, notmuch::patch, unread]
                • Jameson Graef Rollins—[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Jameson Graef Rollins—[PATCH 8/8] emacs: eliminate show-tag-message in favor of just show-tag [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
                    • Jameson Graef Rollins—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, signed, unread]
                      • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
                  • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
              • Mark Walters—Re: [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, unread]
                • Jameson Graef Rollins—Re: [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, signed, unread]
        • Mark Walters—Re: [PATCH 2/8] emacs: update tag-completion function [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH 2/8] emacs: update tag-completion function [inbox, signed, unread]
    • Jameson Graef Rollins—emacs tagging cleanup, v3 [inbox, unread]
      • Jameson Graef Rollins—[PATCH 1/5] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el [inbox, notmuch::patch, notmuch::pushed, unread]
        • Jameson Graef Rollins—[PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 3/5] emacs: modify search tag functions to use new notmuch-tag interface [inbox, notmuch::patch, notmuch::pushed, unread]
            • Jameson Graef Rollins—[PATCH 4/5] emacs: modify show tag functions to use new notmuch-tag interface [inbox, notmuch::patch, notmuch::pushed, unread]
              • Jameson Graef Rollins—[PATCH 5/5] emacs: eliminate search-tag-thread in favor of just search-tag [inbox, notmuch::patch, notmuch::pushed, unread]
          • Mark Walters—Re: [PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—[PATCH v2 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::patch, notmuch::pushed, unread]
      • Tomi Ollila—Re: emacs tagging cleanup, v3 [inbox, notmuch::review, unread]