Tomi Ollila <tomi.ollila@iki.fi> writes:

> This is second draft patch of (first being)
>
> id:1405026779-29966-1-git-send-email-tomi.ollila@iki.fi
>
> I saw potential problem with only supporting emacsclient(1) in
> the version David sent:
> id:1421598115-4889-1-git-send-email-david@tethera.net
>
> (no emacs server running and no tty -- new X client not started)
>

I don't understand what use case is failing for you. I think I tested
all 4 combinations of DISPLAY set and unset and emacs server running and
not running.  Do you somehow want to run the notmuch-emacs-mua script
from a process not attached to a terminal (from cron?).

> In case emacsclient(1) is used and no --no-window-system, '-c' arg is
> given to emacsclient like in the version David sent.
>
> (this means that if emacs is not running on X, user may get this message:
>  "emacsclient: could not get terminal name" -- we need to document user
>  to give -nw (--no-window-system) option then)

As I wrote above, I'm missing what the tradeoff is. The version I sent
works fine (at least for me) in the case where DISPLAY is not set and
--no-window-system is not given (i.e. it's implied if DISPLAY is not
set).

d