Re: [PATCH] sprinters: bugfix when NULL passed for a string.

Subject: Re: [PATCH] sprinters: bugfix when NULL passed for a string.

Date: Wed, 08 Aug 2012 09:25:49 -0700

To: Mark Walters, Austin Clements, Ben Gamari, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Wed, Aug 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> For the From/Date headers see http://www.ietf.org/rfc/rfc2822.txt
> section 3.6 for details:
>
>    The only required header fields are the origination date field and
>    the originator address field(s).  All other header fields are
>    syntactically optional.
>
> and origination date field means a Date: header, and originator
> address field means a From: header. However, I don't think an empty
> string is valid for either of these so we can't sensibly output
> something standards compliant. Thus I would go for following the
> original message and omit any fields not present in it.

I agree.  Let's not pretend or imply something is valid when it's not.
The output should reflect the actual content of the message as much as
possible.

jamie.
part-000.sig (application/pgp-signature)

Thread: