Re: [PATCH v5 0/5] New output format sexp (Lisp S-Expressions)

Subject: Re: [PATCH v5 0/5] New output format sexp (Lisp S-Expressions)

Date: Thu, 06 Dec 2012 22:13:57 +0000

To: Peter Feigl, notmuch@notmuchmail.org

Cc:

From: Mark Walters


On Thu, 06 Dec 2012, Peter Feigl <craven@gmx.net> wrote:
> This patch series adds a new output format "sexp" to notmuch-reply,
> notmuch-show and notmuch-search. These are useful for the Android mobile
> client, Emacs and perhaps other Lisp programs as well.
> After the switch to a generic structured output printer, which was
> committed some months ago, these patches just add another one (like the
> json structured output printer).
> Basic tests and updates to the man pages are also included.
>
> This version adresses comments by Tomi Ollila and Austin Clements.

This looks good to me except there are a couple of trailing whitespace
errors

Best wishes

Mark


>
> Old versions:
> v4: id:cover.1354794428.git.craven@gmx.net
> v3: id:1354779189-12231-1-git-send-email-craven@gmx.net
> v2: id:1354632382-15609-1-git-send-email-craven@gmx.net
> v1: 1354264143-30173-1-git-send-email-craven@gmx.net
>
> Peter Feigl (5):
>   Adding an S-expression structured output printer.
>   Rename the -json printer functions in notmuch-reply and notmuch-show
>     to generic -sprinter functions.
>   Use the S-Expression structured printer in notmuch-show,
>     notmuch-reply and notmuch-search.
>   Adding tests for --format=sexp.
>   Updating man pages for new S-Expression output format.
>
>  Makefile.local            |   1 +
>  devel/schemata            |  24 +++--
>  man/man1/notmuch-reply.1  |  14 ++-
>  man/man1/notmuch-search.1 |  15 +--
>  man/man1/notmuch-show.1   |  36 +++++--
>  notmuch-client.h          |   8 +-
>  notmuch-reply.c           |  48 ++++++----
>  notmuch-search.c          |   6 +-
>  notmuch-show.c            |  76 ++++++++-------
>  sprinter-sexp.c           | 235 ++++++++++++++++++++++++++++++++++++++++++++++
>  sprinter.h                |   4 +
>  test/notmuch-test         |   1 +
>  test/sexp                 |  48 ++++++++++
>  13 files changed, 434 insertions(+), 82 deletions(-)
>  create mode 100644 sprinter-sexp.c
>  create mode 100755 test/sexp
>
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: