Re: [PATCH 5/6] cli: add global option "--db-revision"

Subject: Re: [PATCH 5/6] cli: add global option "--db-revision"

Date: Fri, 07 Aug 2015 22:47:07 +0200

To: Daniel Schoepe, notmuch@notmuchmail.org

Cc:

From: David Bremner


Daniel Schoepe <daniel@schoepe.org> writes:

> On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote:
>> +    ``--db-revision=UUID``
>> +       Enforce that the database revision is UUID. This is useful to
>> +       detect rollover in modification counts on messages. You can
>> +       find this UUID in the first column of output from
>> +       ``notmuch count --output=modifications``
>
> I'm not sure if the wording here is entirely clear. When reading this
> the first time, to me it sounded like it might give you a view of the
> database from when the revision was UUID. Maybe we can clarify here that
> this will result in notmuch exiting if the revision is not matched.

Sure, no problem with expanding what "Enforce" means. Some improvment of
the names as discussed in a previous message might help here also.

d

Thread: