Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

Subject: Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

Date: Sun, 13 Nov 2016 07:34:59 +0000

To: David Bremner, Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Mark Walters

On Sat, 12 Nov 2016, David Bremner <david@tethera.net> wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> Like someone (whose message I cannot find just now) mentioned in another
>> thread, just now it is right time to mention here too...
>>
>> https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html
>>
>> ... that when hook name ends with `-hook` it is supposed to be "normal hook"
>> -- a function which does not take arguments nor return values.
>>
>> So, I'd like to suggest that this variable is renamed to 
>> notmuch-address-completion-functions
>>
>
> Well, I guess the -functions convention should be followed, but
> notmuch-address-completion-functions seems a bit vague.

Maybe notmuch-address-post-completion-functions ?

Alternatively maybe we can end in -hook-functions to indicate it is a
function which is like a hook?

Best wishes

Mark

Thread: