Re: [PATCH] fix notmuch_database_open call in addrlookup

Subject: Re: [PATCH] fix notmuch_database_open call in addrlookup

Date: Wed, 07 Nov 2012 20:45:29 -0500

To: Ethan Glasser-Camp, notmuch mailing list

Cc:

From: James Vasile


James Vasile <james@hackervisions.org> writes:
> Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
>
>> James Vasile <james@hackervisions.org> writes:
>>
>>> What's the best way to submit changes to addrlookup?  Right now, it is
>>> out of date vs the latest libnotmuch.  The addrlookup repo is vala code
>>> but the wiki [1] points to a generated c file [2].
>>>
>>> [1] http://github.com/spaetz/vala-notmuch/raw/static-sources/src/addrlookup.c
>>> [2] http://notmuchmail.org/emacstips/
>>>
>>> At any rate, a patch to that c file is below.  If you upgraded notmuch
>>> and now addrlookup gives errors about not finding libnotmuch.so.2, this
>>> patch might be what you need.
>>
>> I'd try to contact the author of the code, perhaps by submitting an
>> issue or pull request on the github page for the project. I'm sure he'd
>> prefer a patch to the Vala source.
>>
>> Ethan
>
> Thanks, will do.  My vala is weak, so a patch to the vala source is
> unlikely to make it to the front of my queue this year.  I'll ping
> Sebastian Spaeth directly and via github.
>
> -J

Just to close the loop: I contacted Sebastian and he applied my patch.
I tested the instructions on the wiki and confirmed they are currently
correct against his tree.  He notes that he doesn't currently have time
to monitor the list closely.

Thanks,
-J
part-000.sig (application/pgp-signature)

Thread: