On Sat, 14 Apr 2012, Mark Walters <markwalters1009@gmail.com> wrote: > On Sat, 14 Apr 2012, Peter Wang <novalazy@gmail.com> wrote: >> Changes from v3: >> - rephrase part of the 'list' implementation as a separate patch >> - test 'set' on an extant key >> - test removing keys > > This looks good to me. +1 > > Two minor comments which you might like to consider (but definitely are > not required): > 1) You could check that there are no further arguments when the user > calls `notmuch config list' > 2) In the man page you could explicitly say what the output is for a > configuration item which has not been set. > > Best wishes > > Mark Just to make it completely clear the above was not meant to delay acceptance of this series: I am quite happy with it as is. Best wishes Mark