Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Date: Fri, 12 Oct 2012 17:36:31 -0400

To: Pieter Praet, Notmuch Mail

Cc:

From: Ethan Glasser-Camp

Pieter Praet <pieter@praet.org> writes:

> * emacs/notmuch-show.el
>
>   (notmuch-show-toggle-headers):
>     Rename to `notmuch-show-toggle-visibility-headers'.

This patch, and its predecessors, all look great to me. The following
patches were already marked "stale" (and indeed they don't apply). But
it looks like David Edmonson gave his +1 on the idea, so maybe you
should rebase them.

Side note: how do you write these tests? How do you generate what the
output should look like? Copy/paste from a "real" emacs session? You
have generated an awful lot of tests :)

Ethan

• Previous message (by thread): Re: [PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers"

Thread:

• Pieter Praet—[PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, signed, unread]
    • Tomi Ollila—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
    • Pieter Praet—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
      • David Edmondson—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, signed, unread]
  • Tomi Ollila—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, unread]
  • Dmitry Kurochkin—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, unread]
    • Pieter Praet—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
  • Pieter Praet—[PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers" [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
    • David Bremner—Re: [PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers" [inbox, unread]
  • Pieter Praet—[PATCH v2 2/7] test: emacs: new tests "notmuch-show: {, un}collapse all messages in thread" [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
  • Pieter Praet—[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    • Ethan Glasser-Camp—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, notmuch::review, unread]
      • Ethan Glasser-Camp—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
        • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
        • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
          • Ethan—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
            • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
  • Pieter Praet—[PATCH v2 4/7] emacs: rename `notmuch-show-toggle-message' to `notmuch-show-toggle-visibility-message' [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 5/7] emacs: rename `notmuch-show-open-or-close-all' to `notmuch-show-toggle-visibility-messages' [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 6/7] emacs: make `notmuch-show-toggle-visibility-messages' live up to its new name [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 7/7] emacs: `notmuch-show-toggle-visibility-messages' with prefix arg filters by tag [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, notmuch::wip, unread]