Re: [PATCH 0/3] Add notmuch-pick to contrib

Subject: Re: [PATCH 0/3] Add notmuch-pick to contrib

Date: Mon, 29 Oct 2012 08:28:20 +0000

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Mark Walters


Hello

On Sun, 28 Oct 2012, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> This is a new version of notmuch-pick (previous version at
>> id:"1343164911-31589-1-git-send-email-markwalters1009@gmail.com")following
>> suggestions of Tomi and David in that thread. The main change is that
>> it is now entirely self contained in contrib: all the user needs to do
>> is copy the notmuch-pick.el somewhere in the emacs load path and add
>> (require 'notmuch-pick nil t) to their .emacs file.
>
> I have pushed this to contrib.

That's great.

> We do need tests before this goes mainline. What about (untested) having
> the tests in contrib/notmuch-pick for now, including as needed from
> ../../test.

I haven't been able to get this to work but I have a slight variant
which seems to that I will post shortly.

> We should mention it in NEWS; at this point I think it is reasonable to
> expect to do at least one release with pick in contrib.

Yes that seems sensible.

> As a vague feature request, what about forwarding unknown keys to
> the notmuch-show buffer?

This would be good: but I can't see how to make it work. If anyone has
any suggestions or pointers do say!

Best wishes

Mark


Thread: