Re: [PATCH v3 0/2] notmuch hooks

Subject: Re: [PATCH v3 0/2] notmuch hooks

Date: Wed, 07 Dec 2011 14:13:13 -0800

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula <jani@nikula.org> wrote:
> I wonder, though, whether the samples should be created only when
> creating the database, or whenever the hooks directory does not exist?
> The latter, I guess. Otherwise existing notmuch users would hardly get
> the sample hooks.

I agree, the later would be better.  notmuch new should just create the
hooks directory (and example scripts) if they don't already exist.

I also think it's nice to have the scripts not executable to begin with,
and the hook runner only executes the script if they are executable.

jamie.
part-000.sig (application/pgp-signature)

Thread: