On Thu, 08 May 2014, David Edmondson <dme@dme.org> wrote: > emacs: Improve the cited message included in replies > > v2: > - Don't run the text/plain hooks when generating the message to quote. > In principle I like this approach: keeping show and reply closely linked seems good. At the moment, as you say, the tests don't all pass. The first reason is that this puts in buttons for the parts. Stopping that happening is not completely trivial as we need to make sure that the instruction gets passed down to sub-parts of multiparts etc. (You could argue that the 'no-button option to notmuch-show-insert-bodypart is buggy as it only stops the top level button for the part) Secondly, the existing code only includes text sub-parts of the message. I would think your version might include any sub-parts show is configured to display, including, say images. (However, in my testing images didn't seem to be included: I am not sure why.) I can't tell how much work it is to modify show to take account of these things, so am not sure if this is the best approach, or just adding something to deal with rfc822 to our existing reply code is easier. Best wishes Mark