Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

Subject: Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

Date: Tue, 01 Nov 2011 20:57:59 +0100

To: Thomas Jost, notmuch@notmuchmail.org

Cc:

From: Pieter Praet

On Mon,  3 Oct 2011 18:47:18 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> [...]

Nice catches @

  - "Sending a message via (fake) SMTP"
  - "Hiding message following HTML part"

(though I think the latter test wasn't there yet when I submitted my
patch series)


New "issues":

  - The SCREEN prereq would preferrably be added in a separate commit.

  - @ "Verify that sent messages are saved/searchable (via FCC)":

    This doesn't need an EMACS prereq.

  - @ "Reply within emacs":

    `sed' will want to treat "EMACS" as an input file, so I think you
    meant to do this:

      test_have_prereq EMACS \
        && sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT


Peace

-- 
Pieter

• Previous message (by thread): Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Thread:

• Dmitry Kurochkin—[PATCH 1/3] test: update documentation for test_emacs in test/README [inbox, notmuch::patch, notmuch::pushed, unread]
  • Dmitry Kurochkin—[PATCH 2/3] test: improve known broken tests support [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—Re: [PATCH 2/3] test: improve known broken tests support [inbox, notmuch::review, unread]
      • Dmitry Kurochkin—Re: [PATCH 2/3] test: improve known broken tests support [inbox, unread]
  • Dmitry Kurochkin—[PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
        • David Bremner—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
            • Thomas Jost—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, signed, unread]
              • Dmitry Kurochkin—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
              • David Bremner—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
                • Thomas Jost—[PATCH 00/13] Test prereqs and screen-based Emacs tests [inbox, unread]
                  • Thomas Jost—[PATCH 01/13] test: define a helper function for defining prereqs on executables [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 02/13] test: add 'GnuPG' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Pieter Praet—Re: [PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests [inbox, notmuch::review, unread]
                      • Pieter Praet—Re: [PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests [inbox, unread]
                  • Thomas Jost—[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Pieter Praet—Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests [inbox, notmuch::review, unread]
                      • Pieter Praet—Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests [inbox, unread]
                  • Thomas Jost—[PATCH 05/13] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 06/13] test: run emacs inside screen [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Jameson Graef Rollins—Re: [PATCH 06/13] test: run emacs inside screen [inbox, notmuch::bug, notmuch::obsolete, signed, unread]
                      • Thomas Jost—Re: [PATCH 06/13] test: run emacs inside screen [inbox, signed, unread]
                  • Thomas Jost—[PATCH 07/13] test: avoid using screen(1) configuration files [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 08/13] test: do not set frame width in emacs [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 09/13] test: `notmuch-show-advance-and-archive' with invisible signature [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 10/13] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 11/13] emacs: remove no longer used functions from notmuch-show.el [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 12/13] emacs: remove unused `point-invisible-p' function [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Thomas Jost—[PATCH 13/13] test: make smtp-dummy work with Emacs 24 [inbox, notmuch::patch, notmuch::portability, notmuch::pushed, notmuch::test, unread]
                    • David Bremner—Re: [PATCH 13/13] test: make smtp-dummy work with Emacs 24 [inbox, unread]
                  • Pieter Praet—Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests [inbox, unread]
                    • David Bremner—Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests [inbox, unread]
                      • Pieter Praet—Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests [inbox, unread]
    • David Bremner—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
      • Tom Prince—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
        • Dmitry Kurochkin—Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part [inbox, unread]
  • Dmitry Kurochkin—[PATCH v2 0/3] improved broken tests support and test for a bug [inbox, notmuch::pushed, unread]
    • Dmitry Kurochkin—[PATCH v2 1/3] test: update documentation for test_emacs in test/README [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
    • Dmitry Kurochkin—[PATCH v2 2/3] test: improve known broken tests support [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file [inbox, unread]
          • David Bremner—Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file [inbox, unread]
            • Dmitry Kurochkin—Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file [inbox, unread]
              • david@tethera.net—[PATCH] test: reset test_subtest_known_broken_ after each success/failure. [inbox, notmuch::patch, notmuch::pushed, unread]
                • Dmitry Kurochkin—Re: [PATCH] test: reset test_subtest_known_broken_ after each success/failure. [inbox, unread]
                  • David Bremner—Re: [PATCH] test: reset test_subtest_known_broken_ after each success/failure. [inbox, unread]
    • Dmitry Kurochkin—[PATCH v2 3/3] test: add emacs test for hiding a message following an HTML part [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 0/3] improved broken tests support and test for a bug [inbox, unread]