Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

Date: Mon, 13 Feb 2012 18:16:44 +0000

To: Aneesh Kumar K.V, notmuch@notmuchmail.org

Cc:

From: Mark Walters


On Mon, 13 Feb 2012 14:35:31 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly 
> > to master since Jani's notmuch-show command line parsing 
> > has been pushed.
> > 
> > It includes the significant bug fix (at least for anyone working 
> > with a dark background) from Daniel making matched messages 
> > highlight color both configurable and have a sensible default.
> > These are in the notmuch-pick subgroup of the customize menus.
> > 

Hi

> Really nice patchset. It would be really nice if we can get the serach
> limit patchset before this. That way the pick result will be limitted.

Do you mean id:"1327692900-22926-1-git-send-email-jani@nikula.org"? That
would not affect notmuch-pick. In fact, since notmuch-pick uses
notmuch-show.c rather than notmuch-search.c the cli doesn't have the
--limit option. You are quite right that this may be the way to go
though.

> I also noticied that mails are not marked as read when i select them in
> the notmuch-pick mode. Also for me the tree structures appears as
> below. 

Are they not marked as read at all, or just not marked as read in the
notmuch-pick display (try pressing '=' and see if they are shown
correctly on refresh). It would be very nice to have the tags refresh
automatically but I have not implemented it (it may be beyond my lisp-fu).

>  Today 00:19  Mark Walters          ├┬►[RFC PATCH v2 1/3] cli: notmuch-show changes to support pick (notmuch)
>  Today 02:38  Daniel Schoepe        │├─► ...                                              (notmuch, signed)
>  Today 03:38  Mark Walters          │╰─► ...                                              (notmuch)
>  Today 00:19  Mark Walters          ├┬►[RFC PATCH v2 2/3] emacs: changes to other files to support notmuch-pick (notmuch)
>  Today 03:57  Mark Walters          │╰─► ...                                              (notmuch)
>  Today 00:19  Mark Walters          ├─►[RFC PATCH v2 3/3] emacs: add notmuch-pick itself  (notmuch)

I am not quite sure what this looks like (as I am not sure what is my
emacs doing things and what is what you sent. Could you send me a
screenshot (and an explanation of what is wrong if it is not clear from
the screenshot)?

Thanks

Mark

Thread: