Re: [PATCH v2 0/7] emacs: JSON-based search cleanups

Subject: Re: [PATCH v2 0/7] emacs: JSON-based search cleanups

Date: Sat, 14 Jul 2012 12:06:17 -0700

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Fri, Jul 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> This version updates the docstrings for notmuch-search-update-result
> and notmuch-search-show-result and fixes the scrolling artifact in
> notmuch-search-update-result.  I also updated the commit message of
> patch 7 to mention that it changes the behavior of
> notmuch-search-previous-thread.

Hey, Austin.  This is a really nice series.  Very nice cleanup, with a
lot of great side effects.  It definitely looks good to me, although
like Mark, I don't quite grok the defmacro in patch 4.  But this is only
my ignorance and not a comment on the patch at all.  I've also tested
and the series seems to work great.  I want to try some multi-line
search results now!

jamie.
part-000.sig (application/pgp-signature)

Thread: