Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

Date: Sat, 13 Apr 2013 07:55:50 +0100

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Mark Walters

On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> Some (declare-function ...) definitions were drifted away from the
> actual (defun ...)'s. To find the drifts and to verify changes
> the following command line was used:
>
> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'

This patch looks good to me +1.

Is it worth making the above command into a test?

Best wishes

Mark


>  emacs/notmuch-hello.el | 2 +-
>  emacs/notmuch-show.el  | 1 -
>  emacs/notmuch-wash.el  | 2 +-
>  3 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index cda79f1..c1c6f4b 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -26,7 +26,7 @@
>  (require 'notmuch-lib)
>  (require 'notmuch-mua)
>  
> -(declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation))
> +(declare-function notmuch-search "notmuch" (&optional query oldest-first target-thread target-line continuation))
>  (declare-function notmuch-poll "notmuch" ())
>  
>  (defcustom notmuch-hello-recent-searches-max 10
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a4d2c12..face2a0 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -38,7 +38,6 @@
>  (require 'notmuch-print)
>  
>  (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))
> -(declare-function notmuch-fontify-headers "notmuch" nil)
>  (declare-function notmuch-search-next-thread "notmuch" nil)
>  (declare-function notmuch-search-show-thread "notmuch" nil)
>  
> diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
> index 826b6f4..80c475c 100644
> --- a/emacs/notmuch-wash.el
> +++ b/emacs/notmuch-wash.el
> @@ -23,7 +23,7 @@
>  
>  (require 'coolj)
>  
> -(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth))
> +(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth &optional hide))
>  
>  ;;
>  
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: