Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database

Subject: Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database

Date: Fri, 26 Sep 2014 22:09:16 +0200

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:


> +	status = notmuch_message_tags_to_maildir_flags (message);

...

> +	/*
> +	 * Note: Unfortunately a failed maildir flag sync might
> +	 * already have renamed the file, in which case the cleanup
> +	 * path will fail.
> +	 */

I'd like to be more explicit about what potentially bad outcomes there
are here.  I guess this message file gets left on disk, unindexed,
perhaps forever if the user never runs notmuch new? Would it make sense
to suggest the user run notmuch new to "recover" these message files?

• Previous message (by thread): Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database

Thread:

• Jani Nikula—[PATCH 00/11] notmuch insert updates [inbox, unread]
  • Jani Nikula—[PATCH 01/11] lib: actually return failures from notmuch_message_tags_to_maildir_flags [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Jani Nikula—[PATCH 02/11] cli/insert: rename check_folder_name to is_valid_folder_name [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Jani Nikula—[PATCH 03/11] cli/insert: move add_file_to_database to a better place [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Jani Nikula—[PATCH 04/11] cli/insert: rename file copy function [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Jani Nikula—[PATCH 05/11] cli/insert: clean up sync_dir [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 06/11] cli/insert: use a single recursive mkdir function [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 07/11] cli/insert: abstract temporary filename generation [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 08/11] cli/insert: rehash file writing functions [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 09/11] cli/insert: add fail path to add_file_to_database [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database [inbox, unread]
  • Jani Nikula—[PATCH 10/11] cli/insert: require succesful message indexing for success status [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH 11/11] cli/insert: add post-insert hook [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—Re: [PATCH 00/11] notmuch insert updates [inbox, unread]
    • Tomi Ollila—Re: [PATCH 00/11] notmuch insert updates [inbox, unread]
      • David Bremner—Re: [PATCH 00/11] notmuch insert updates [inbox, unread]