Re: [PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering

Subject: Re: [PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering

Date: Sat, 01 Nov 2014 10:21:16 +0100

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Michal Sojka


On Sat, Nov 01 2014, Jani Nikula wrote:
> On Fri, 31 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
>> This option allows to configure the criterion for duplicate address
>> filtering. Without this option, all unique combinations of name and
>> address parts are printed. This option allows to filter the output
>> more, for example to only contain unique address parts.
>
> This patch finally makes me think we should have a separate 'notmuch
> address' command for all of this. We are starting to have two orthogonal
> sets of 'notmuch search' options, one set for search and another for
> addresses. I regret not following the series and then making the
> observation so late.

To some extent it is true. The question is whether it would make sense
for 'notmuch address' to have options like --offset and --limit.
Probably not.

I can prepare a new patchset implementing 'notmuch address' over the
weekend. It would be necessary to revert the last (or two) already
merged patch. What do others think?

-Michal

Thread: