LGTM. We should probably be paying attention to the content disposition, but this is a definite improvement on what we do now. As an interesting side-note, this lets us inline a handful of types that we previously wouldn't, like application/emacs-lisp. On Sat, 26 Nov 2011 05:44:38 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > Before the change, there was a workaround to avoid notmuch show calls > for parts with application/* Content-Type. But non-inlinable parts > are not limited to this Content-Type (e.g. mp3 files have audio/mpeg > Content-Type and are not inlinable). For such parts > `notmuch-show-insert-part-*/*' handler is called which unconditionally > fetches contents for all parts. > > The patch moves content fetching from `notmuch-show-insert-part-*/*' > to `notmuch-show-mm-display-part-inline' function after MIME inlinable > checks are done to avoid useless notmuch show calls. The > application/* hack is no longer needed and removed. > --- > emacs/notmuch-show.el | 17 +++++------------ > test/emacs | 1 - > 2 files changed, 5 insertions(+), 13 deletions(-) Yay!