Re: [PATCH] build: add "set -e" to version script generation

Subject: Re: [PATCH] build: add "set -e" to version script generation

Date: Tue, 28 Jul 2015 21:41:43 +0200

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Jul 27 2015, David Bremner <david@tethera.net> wrote:
>
>> It turns out that on certain systems like FreeBSD, c++filt is not
>> installed by default. It's basically OK if we fail the build in that
>> case, but what's really not OK is for the build to continue and
>> generate bad binaries.
>> ---
>>  lib/gen-version-script.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
>> index 64a7374..aa1ca43 100644
>> --- a/lib/gen-version-script.sh
>> +++ b/lib/gen-version-script.sh
>> @@ -1,3 +1,4 @@
>> +set -e
>
> LGTM, although I'd prefer 'set -eu' (both visual observation and testing
> with set -eux worked for me).
>

OK, pushed with set -eu.

d

Thread: