Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it

Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it

Date: Sun, 06 Apr 2014 15:42:06 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> +;; You should have received a copy of the GNU General Public License
> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.

Do you think we need a copyright header in a generated file?

> +
> +(defconst notmuch-emacs-version %VERSION%
> +  "Version string of this version of Notmuch Emacs MUA.")
> +

At the risk of being very picky, how about less copies of Version, maybe
"Version of Notmuch Emacs MUA"

Other than that, the series looks OK, and works on Debian now.

d

• Previous message (by thread): Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it

Thread:

• Tomi Ollila—[PATCH v4 1/3] build: write version.stamp file containing $(VERSION) string [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—[PATCH v4 1/3] build: write version.stamp file containing $(VERSION) string [inbox, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—[PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, unread]
      • Tomi Ollila—Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, unread]
        • David Bremner—Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, unread]
  • Tomi Ollila—[PATCH v4 3/3] emacs: defun notmuch-hello-versions and bind 'v' in hello mode to it [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—[PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it [inbox, unread]