Re: [notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop

Subject: Re: [notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop

Date: Wed, 18 Nov 2009 03:31:23 -0800

To: Alex Botero-Lowry, notmuch@notmuchmail.org

Cc:

From: Carl Worth

On Tue, 17 Nov 2009 16:23:53 -0800, Alex Botero-Lowry <alex.boterolowry@gmail.com> wrote:
> In this case error out when no query is supplied. There seems to be an
> infinite-loop casued by i think notmuch_query_search_threads having
> an exception:
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> 
> I'll look into that bug specifically a bit later.
> 
> It might be better to do a usage instead of just throwing an error here?

Definitely.

Priit Laes reported the same thing in IRC and I've just committed a
patch to give a nice error message:

$ ./notmuch search
Error: notmuch search requires at least one search term.

Thanks for the report!

-Carl

Thread: