Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

Subject: Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

Date: Sat, 12 Nov 2016 17:39:31 -0400

To: Tomi Ollila, Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> Like someone (whose message I cannot find just now) mentioned in another
> thread, just now it is right time to mention here too...
>
> https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html
>
> ... that when hook name ends with `-hook` it is supposed to be "normal hook"
> -- a function which does not take arguments nor return values.
>
> So, I'd like to suggest that this variable is renamed to 
> notmuch-address-completion-functions
>

Well, I guess the -functions convention should be followed, but
notmuch-address-completion-functions seems a bit vague.

d

Thread: