Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Subject: Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Date: Mon, 26 Sep 2011 21:25:08 +0400

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Dmitry Kurochkin


Hi David.

On Mon, 26 Sep 2011 08:01:16 -0300, David Bremner <david@tethera.net> wrote:
> On Mon,  4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Result: nothing happens except for "No URL at point" message
> > 
> > Expected result: the second message is shown/hidden
> 
> I didn't track out why so far, but this test is show as FIXED when
> compiled in a Debian chroot.
> 
> see e.g.
>     
>      https://buildd.debian.org/status/fetch.php?pkg=notmuch&arch=kfreebsd-amd64&ver=0.9%7Erc1-1&stamp=1316965004
> 
> Someone else also reported this on the IRC channel; not sure if that was
> Debian or somewhere else.
> 

I see it failing on my system (Debian unstable).  But I have some more
patches on top of master.

Most likely the test passes because emacs is run in server mode and
visibility stuff works differently.  I sent a patch series [1] to run
emacs in screen exactly for this reason.  Please consider pushing it.
Then the test should fail as expected.

Note, if you push the series, a new dependency would be required to run
the tests - screen(1).  Also, the emacs tests should handle missing
screen(1) better using prereqs.  But there are no prereqs for emacs and
gpg anyway... [2]

Regards,
  Dmitry

[1] id:"1309496122-4965-1-git-send-email-dmitry.kurochkin@gmail.com"
[2] id:"874o2germq.fsf@gmail.com"

> d

Thread: