Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

Subject: Re: [PATCH v2 1/2] emacs: create patch filename from subject for inline patch fake parts

Date: Mon, 26 Dec 2011 12:38:35 -0800

To: Jani Nikula, David Edmondson, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Mon, 26 Dec 2011 14:24:42 +0200, Jani Nikula <jani@nikula.org> wrote:
> > Clicking on the button for the part saves the wrong thing, though,
> > because it's not a real MIME part. That looks a bit awkward to fix, so
> > perhaps you could still prefix the name with "inline: " to indicate that
> > it's odd?
> 
> I'm not sure I follow you here. Could you elaborate what you mean by
> "the wrong thing", please?

Yes, this is a problem/bug with the current behavior of these fake
inline parts, actually.  The button should behave as those it is
representing an actual MIME part of the message.  However, clicking the
button saves the entire part that the fake part is derived from, rather
than just the data in the fake part.  This is countereintuitive and
confusing.

> I don't think the user would want to have an "inline: " prefix in the
> filename that would have to be removed every time. I think that kind of
> defeats the purpose here. Or where exactly are you proposing to have the
> prefix?

It's confusing to have this fake part button look just like a real part
button, without any indication that it's really a fake part, and then to
behave differently as well.  The button needs some indication that it
does not represent a real mime part of the message.  Giving the fake
part a proper filename is fine, but it needs some other indicator that
the part is fake and that the button is not going to behave as expected.

jamie.
part-000.sig (application/pgp-signature)

Thread: