Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

Date: Mon, 05 Nov 2012 23:12:39 -0500

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Ethan Glasser-Camp


Tomi Ollila <tomi.ollila@iki.fi> writes:

> Added FILE, notmuch_show_params_t and sprinter_t to be
> types when uncrustifying sources. This affect spacing
> when uncrustify is deciding for type declaration instead
> of binary multiplication operation.

This looks good to me. If you had plenty of time and no more patches to
review, I'd prefer the slightly cleaner English:

This affects how uncrustify puts spacing around pointers to these types,
since it can parse them as type declarations instead of binary
multiplication operations.


... but even suggesting this indicates I've moved past the bike shed and
into somebody else's kitchen.

Ethan

Thread: