[PATCH] devel/check-out-of-tree-build.sh: consistent naming, consistent quoting

Subject: [PATCH] devel/check-out-of-tree-build.sh: consistent naming, consistent quoting

Date: Tue, 3 Oct 2017 08:18:25 +0300

To: notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Tomi Ollila


Renamed from out-of-tree-build-check.sh to be consistent with
other files in this directory.

Fixed quoting in "$srcdir" usage for additional robustness, other
quoting changes for consistency.
---

Probably the review email message of this I sent got buried in the
pile of other email messages ;)

Tomi

 devel/{out-of-tree-build-check.sh => check-out-of-tree-build.sh} | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
 rename devel/{out-of-tree-build-check.sh => check-out-of-tree-build.sh} (57%)

diff --git a/devel/out-of-tree-build-check.sh b/devel/check-out-of-tree-build.sh
similarity index 57%
rename from devel/out-of-tree-build-check.sh
rename to devel/check-out-of-tree-build.sh
index 984b4b5f65f5..3e443ea25bf2 100755
--- a/devel/out-of-tree-build-check.sh
+++ b/devel/check-out-of-tree-build.sh
@@ -4,12 +4,12 @@
 
 set -eu
 
-srcdir="$(cd "$(dirname "$0")"/.. && pwd)"
+srcdir=$(cd "$(dirname "$0")"/.. && pwd)
 builddir=$(mktemp -d)
 
-cd $builddir
+cd "$builddir"
 
-$srcdir/configure
+"$srcdir"/configure
 make "$@"
 
-rm -rf $builddir
+rm -rf "$builddir"
-- 
2.13.3

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: