Re: [PATCH 07/14] test: Tests for future version and unknown feature handling

Subject: Re: [PATCH 07/14] test: Tests for future version and unknown feature handling

Date: Sun, 27 Jul 2014 12:12:22 -0400

Quoth Mark Walters on Jul 27 at  9:51 am:
> 
> On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> > ---
> >  test/T530-upgrade.sh | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> 
> Hi
> 
> Just a quick comment on this patch so far. After this patch I got lots
> of test failures in the second (old) part of T530-upgrade because I
> hadn't downloaded the test databases: prior to this patch no tests
> failed because those tests were skipped.
> 
> Once I downloaded the databases everything was fine again so the problem
> is just that this patch is breaking the automatic skipping of the
> old tests in T530-upgrade.

Oh.  Apparently the prereq stuff only works before the first call to
test_begin_subtest.  Maybe I should just move the subtests I added to
a separate top-level test?

Previous message (by thread): Re: [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features"

Thread:

Austin Clements—[PATCH 0/14] Implement and use database "features" [inbox, unread]
- Austin Clements—[PATCH 01/14] test: Include generated dependencies for test sources [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 02/14] util: Make string-util.h C++-compatible [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
- Austin Clements—[PATCH 03/14] util: Const version of strtok_len [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
- Austin Clements—[PATCH 04/14] new: Don't report version after upgrade [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 04/14] new: Don't report version after upgrade [inbox, unread]
    - Austin Clements—Re: [PATCH 04/14] new: Don't report version after upgrade [inbox, unread]
- Austin Clements—[PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" [inbox, unread]
    - Austin Clements—Re: [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" [inbox, unread]
- Austin Clements—[PATCH 06/14] test: Tool to build DB with specific version and features [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 07/14] test: Tests for future version and unknown feature handling [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 07/14] test: Tests for future version and unknown feature handling [inbox, unread]
    - Austin Clements—Re: [PATCH 07/14] test: Tests for future version and unknown feature handling [inbox, unread]
- Austin Clements—[PATCH 08/14] lib: Simplify upgrade code using a transaction [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 08/14] lib: Simplify upgrade code using a transaction [inbox, unread]
    - Austin Clements—Re: [PATCH 08/14] lib: Simplify upgrade code using a transaction [inbox, unread]
- Austin Clements—[PATCH 09/14] lib: Use database features to drive upgrade [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 10/14] lib: Reorganize upgrade around document types [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 11/14] lib: Report progress for combined upgrade operation [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 12/14] lib: Support empty header values in database [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 13/14] lib: Return an error from operations that require an upgrade [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 14/14] lib: Update doc of notmuch_database_{needs_upgrade, upgrade} [inbox, notmuch::obsolete, notmuch::patch, unread]