Re: [Patch v4 0/8] emacs: show tag changes in buffer

Subject: Re: [Patch v4 0/8] emacs: show tag changes in buffer

Date: Sat, 22 Mar 2014 10:50:05 -0400

To: Mark Walters

Cc: notmuch@notmuchmail.org

From: Austin Clements

LGTM.  Ship it!

Quoth Mark Walters on Mar 22 at 11:51 am:
> This is v4 of this patch set. V3 is at
> id:1394597397-8486-1-git-send-email-markwalters1009@gmail.com. This
> addresses all the review comments from Austin.
> 
> Patches 1-3 and 6-8 are unchanged. For patch 5 I have changed the
> comments slightly, tried to make the unread deleted case clearer by
> using the new `bare-tag' variable, and added all three custom format
> variables to the notmuch-faces group.
> 
> For patch 6 I have switched to Austin's suggested approach with the
> changes mentioned in id:87pplek4v0.fsf@qmul.ac.uk and
> id:87mwgih2zx.fsf@qmul.ac.uk
> 
> Best wishes
> 
> Mark

• Previous message (by thread): Re: [Patch v4 0/8] emacs: show tag changes in buffer

Thread:

• Mark Walters—[Patch v4 0/8] emacs: show tag changes in buffer [inbox, unread]
  • Mark Walters—[Patch v4 1/8] emacs: Combine notmuch-combine-face-text-property{, -string} [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 2/8] Make keys of notmuch-tag-formats regexps and use caching [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 3/8] emacs: tag split customise option for format-tags into a widget [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 4/8] emacs: tag: add customize for deleted/added tag formats [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 5/8] emacs: show: mark tags changed since buffer loaded [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 6/8] emacs: show: use orig-tags for tag display [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 7/8] emacs: search: use orig-tags in search [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[Patch v4 8/8] emacs: tree: use orig-tags in search [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—Re: [Patch v4 0/8] emacs: show tag changes in buffer [inbox, notmuch::review, unread]
    • Jani Nikula—Re: [Patch v4 0/8] emacs: show tag changes in buffer [inbox, unread]
  • David Bremner—Re: [Patch v4 0/8] emacs: show tag changes in buffer [inbox, unread]