Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

Date: Tue, 18 Feb 2014 10:48:04 -0800

To: Tomi Ollila

Cc: notmuch@notmuchmail.org

From: W. Trevor King

On Tue, Feb 18, 2014 at 08:34:52PM +0200, Tomi Ollila wrote:
> -        def __values__(self):
> +        def values(self):

Looks good to me.  I'm not sure why I used __values__ in the first
place; probably just in the __ zone after __init__ and __setitem__.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

• Previous message (by thread): Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

Thread:

• Tomi Ollila—[PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • W. Trevor King—Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub [inbox, notmuch::review, signed, unread]
  • David Bremner—Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub [inbox, unread]