LGTM. Quoth Mark Walters on Jun 10 at 5:57 am: > This is version 5 of this patch set. Version 4 is at > id:1370074547-24677-1-git-send-email-markwalters1009@gmail.com. > > This version fixes the two bugs pointed out in Austin's review > id:20130610023952.GC22196@mit.edu. > > I decided to add the :notmuch-part text property separately from > create-overlays as they have slightly different regions (one includes > the button one does not) and are applied at slightly different times > (we do not create overlays for lazy parts). > > I was not sure whether we created two overlays for hidden lazy parts > in v4 (it might not have done as the part was empty and we do not > create overlays for empty parts) but that is stupidly fragile. Thus we > explicitly do not create overlays for lazy parts until they are > inserted. > > The diff from v4 is below. > > Best wishes > > Mark