Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts

Subject: Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts

Date: Sun, 9 Jun 2013 22:39:52 -0400

To: Mark Walters

Cc: notmuch@notmuchmail.org

From: Austin Clements


Quoth Mark Walters on Jun 01 at  9:15 am:
> This is version 4 of this series. Version 3 is at
> id:1370024806-6616-1-git-send-email-markwalters1009@gmail.com
> 
> Changes from version 3 are: fix the whitespace changes in patch 3/5,
> store both the start of the part and the start of the content in
> insert-bodypart (Austin's part handler series needs one and I need the
> other) and fixed the missing save-excursion in patch 4/5.
> 
> Finally, there is one more substantial change: rebasing on to Austin's
> part handler (now in master). There was a little more to this than I
> expected so for anyone testing please use this version.

This series LGTM except for one bug (also related to my new part
handling, sorry): after expanding a lazy part, the "." submap doesn't
work within that part because it doesn't get the :notmuch-part
property applied to it.  I'm not sure what the best solution to this
is.  Maybe applying :notmuch-part should be moved to
notmuch-show-create-part-overlays?

Also, unrelated: with this series, do we wind up creating a second
overlay when a lazy part is shown?

Thread: