LGTM. Quoth Jani Nikula on Oct 30 at 10:32 pm: > Hi all, v6 of [1] with plenty of small changes addressing Austin's > review [2], [3], [4], and [5]. See my replies to Austin for what I've > agreed to change, and what I've chosen to ignore and why. > > The single biggest change is the requirement to have some delimiter(s) > between keywords, which allowed simplification of keyword > matching. Consequently match_keyword() and parse_keyword() functions in > patch 2/9 have changed considerably. > > There are a few ways to examine the changes since v5. My public repo at > [6] has branches topic-parse-time-string-v5 (rebased to master) and > topic-parse-time-string-v6, and [7] should provide a fancy colorful diff > between the two. The same but less fancy diff is also at the end of this > cover letter. > > Change by change commits to the parser and test tool can also be found > at [8]. The source files there are copied verbatim to patches 2/9 and > 3/9.