Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset

Subject: Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset

Date: Mon, 24 Sep 2012 14:50:50 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Justus Winter

Quoting David Bremner (2012-09-24 12:44:04)
> Justus Winter <4winter@informatik.uni-hamburg.de> writes:
> 
> > We need to discuss where those kind of macro definitions abstracting
> > away compiler differences should go. None of the files in util
> > includes notmuch-private.h, so I was unsure whether it's okay to put
> > them there.
> 
> How about a new header file in util/
> 
> function-attributes.h or something like that?
> 
> The util stuff is "lower level" than lib/ so it makes sense to me to put
> common stuff there.

Maybe we should add this file to compat?

Justus

• Previous message (by thread): Re: [PATCH 1/6] Provide a __has_attribute compatibility macro

Thread:

• Justus Winter—[PATCH 1/2] Annotate internal_error with the attribute noreturn [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Justus Winter—[PATCH 2/2] Avoid potentially dereferencing a NULL pointer [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Austin Clements—Re: [PATCH 2/2] Avoid potentially dereferencing a NULL pointer [inbox, notmuch::review, unread]
      • Justus Winter—Re: [PATCH 2/2] Avoid potentially dereferencing a NULL pointer [inbox, unread]
  • David Bremner—Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn [inbox, unread]
  • Austin Clements—Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn [inbox, notmuch::review, unread]
    • Tomi Ollila—Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn [inbox, unread]
    • Justus Winter—RFC: Annotate internal_error with the attribute noreturn 2nd patchset [inbox, unread]
      • Justus Winter—[PATCH 1/5] RFC: Provide a __has_attribute compatibility macro [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Justus Winter—[PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Justus Winter—[PATCH 3/5] Fix the COERCE_STATUS macro [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Justus Winter—[PATCH 4/5] Annotate internal_error with the attribute noreturn [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Justus Winter—[PATCH 5/5] Avoid potentially dereferencing a NULL pointer [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset [inbox, notmuch::review, unread]
        • Justus Winter—Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset [inbox, unread]
          • David Bremner—Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset [inbox, unread]
            • Justus Winter—[PATCH 1/6] Provide a __has_attribute compatibility macro [inbox, notmuch::patch, notmuch::pushed, unread]
              • Justus Winter—[PATCH 2/6] Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE [inbox, notmuch::patch, notmuch::pushed, unread]
              • Justus Winter—[PATCH 3/6] Extend compat/README [inbox, notmuch::patch, notmuch::pushed, unread]
              • Justus Winter—[PATCH 4/6] Fix the COERCE_STATUS macro [inbox, notmuch::patch, notmuch::pushed, notmuch::review, unread]
                • Austin Clements—Re: [PATCH 4/6] Fix the COERCE_STATUS macro [inbox, unread]
                  • Tomi Ollila—Re: [PATCH 4/6] Fix the COERCE_STATUS macro [inbox, notmuch::review, unread]
              • Justus Winter—[PATCH 5/6] Annotate internal_error with the attribute noreturn [inbox, notmuch::patch, notmuch::pushed, unread]
              • Justus Winter—[PATCH 6/6] Avoid potentially dereferencing a NULL pointer [inbox, notmuch::patch, notmuch::pushed, unread]
              • David Bremner—Re: [PATCH 1/6] Provide a __has_attribute compatibility macro [inbox, unread]