Re: [PATCH v4 0/7] cli: improved crypto internals

Subject: Re: [PATCH v4 0/7] cli: improved crypto internals

Date: Fri, 25 May 2012 10:44:03 -0400

To: Jameson Graef Rollins

Cc: Notmuch Mail

From: Austin Clements

Quoth Jameson Graef Rollins on May 23 at  3:40 pm:
> Ok, hopefully last version.  This addresses Jani's latest comments.
> 
> The first patch uses a typedef to handle the incompatibility between
> the crypto context between GMIME 2.4 and 2.6.  We probably should have
> done this originally, as it gets rid of a bunch of #ifdefs, and should
> help reduce confusion.
> 
> I also move to use strcasecmp for the crypto protocol, with a comment
> that points to the relevant RFCs for justification.

This series LGTM other than the one and a half comments I just sent.

• Previous message (by thread): Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility

Thread:

• Jameson Graef Rollins—[PATCH v4 0/7] cli: improved crypto internals [inbox, unread]
  • Jameson Graef Rollins—[PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—[PATCH v4 2/7] cli: new crypto structure to store crypto contexts and parameters, and functions to support it [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH v4 3/7] cli: modify show and reply to use new crypto struct [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH v4 4/7] cli: modify mime_node_open to take new crypto struct as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH v4 5/7] cli: modify mime_node_context to use the new crypto struct [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH v4 6/7] cli: new crypto verify flag to handle verification [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Jameson Graef Rollins—[PATCH v4 7/7] cli: use new notmuch_crypto_get_context in mime-node.c [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v4 2/7] cli: new crypto structure to store crypto contexts and parameters, and functions to support it [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility [inbox, notmuch::review, unread]
      • Jameson Graef Rollins—Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility [inbox, signed, unread]
        • Austin Clements—Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility [inbox, unread]
        • Tomi Ollila—Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6 incompatibility [inbox, unread]
  • Jani Nikula—Re: [PATCH v4 0/7] cli: improved crypto internals [inbox, notmuch::review, unread]
    • Jameson Graef Rollins—Re: [PATCH v4 0/7] cli: improved crypto internals [inbox, signed, unread]
  • Austin Clements—Re: [PATCH v4 0/7] cli: improved crypto internals [inbox, notmuch::review, unread]