--- Now that I take a second look at the code, I think Austin's original commit is correct, if a bit terse. Here is how I have expanded it in the revised series. lib/database.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 0650c63..bab3334 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -1473,8 +1473,9 @@ notmuch_database_upgrade (notmuch_database_t *notmuch, _notmuch_message_upgrade_folder (message); /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not - * track modification revisions. Give all messages a - * revision of 1. + * track modification revisions. Give all messages the + * next available revision; since we just started tracking + * revisions for this database, that will be 1. */ if (new_features & NOTMUCH_FEATURE_LAST_MOD) _notmuch_message_upgrade_last_mod (message); -- 2.1.4