[PATCH] emacs: jump: sort-order bugfix

Subject: [PATCH] emacs: jump: sort-order bugfix

Date: Tue, 2 Sep 2014 13:30:49 +0100

To: notmuch@notmuchmail.org

Cc:

From: Mark Walters


default-value needs its argument to be quoted.
---

Slightly strangely default-value of 't or nil is 't or nil
respectively so the code didn't give an error but just did the wrong
thing.

Thanks to Jani for finding the bug.

Best wishes

Mark

 emacs/notmuch-jump.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
index 5eb0949..0193f8c 100644
--- a/emacs/notmuch-jump.el
+++ b/emacs/notmuch-jump.el
@@ -51,7 +51,7 @@ (defun notmuch-jump-search ()
 		 (case (plist-get saved-search :sort-order)
 		   (newest-first nil)
 		   (oldest-first t)
-		   (otherwise (default-value notmuch-search-oldest-first)))))
+		   (otherwise (default-value 'notmuch-search-oldest-first)))))
 	    (push (list key name
 			`(lambda () (notmuch-search ',query ',oldest-first)))
 		  action-map)))))
-- 
1.7.10.4


Thread: