[PATCH 5/5] emacs: eliminate search-tag-thread in favor of just search-tag

Subject: [PATCH 5/5] emacs: eliminate search-tag-thread in favor of just search-tag

Date: Sat, 14 Apr 2012 11:52:54 -0700

To: Notmuch Mail

Cc:

From: Jameson Graef Rollins

notmuch-search-tag-thread is now completely redundant with
notmuch-search-tag so we eliminate it to simplify the interface.
---
 emacs/notmuch.el |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index a03a526..cfc3b29 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -517,12 +517,6 @@ and will also appear in a buffer named \"*Notmuch errors*\"."
 	(forward-line 1))
       output)))
 
-(defun notmuch-search-tag-thread (&rest tag-changes)
-  "Change tags for the currently selected thread.
-
-See `notmuch-search-tag-region' for details."
-  (apply 'notmuch-search-tag-region (point) (point) tag-changes))
-
 (defun notmuch-search-tag-region (beg end &optional tag-changes)
   "Change tags for threads in the given region."
   (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
@@ -560,7 +554,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
 
 This function advances the next thread when finished."
   (interactive)
-  (notmuch-search-tag-thread "-inbox")
+  (notmuch-search-tag '("-inbox"))
   (notmuch-search-next-thread))
 
 (defvar notmuch-search-process-filter-data nil
-- 
1.7.9.5

• Previous message (by thread): Re: emacs tagging cleanup, v3

Thread:

• Jameson Graef Rollins—improvements to some emacs search tagging functions [inbox, unread]
  • Jameson Graef Rollins—[PATCH 1/6] emacs: update tag-completion function [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Jameson Graef Rollins—[PATCH 2/6] emacs: have tag-completion return all tags for nil input [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 4/6] emacs: remove redundant notmuch-search-tag-thread function [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
          • Jameson Graef Rollins—[PATCH 5/6] emacs: change name of search-archive-thread function to just search-archive [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
            • Jameson Graef Rollins—[PATCH 6/6] emacs: include tags from excluded messages in tag tab completion [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH 3/6] emacs: modify notmuch-search-tag to not prompt if tags provided as argument [inbox, notmuch::review, unread]
      • Dmitry Kurochkin—Re: [PATCH 2/6] emacs: have tag-completion return all tags for nil input [inbox, notmuch::review, unread]
  • Jameson Graef Rollins—Re: improvements to some emacs search tagging functions [inbox, signed, unread]
  • Jameson Graef Rollins—emacs tagging cleanup [inbox, unread]
    • Jameson Graef Rollins—[PATCH 1/8] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 2/8] emacs: update tag-completion function [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 3/8] emacs: have tag-completion return all tags for nil input [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 4/8] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Jameson Graef Rollins—[PATCH 6/8] emacs: eliminate search-tag-thread in favor of just search-tag [inbox, notmuch::obsolete, notmuch::patch, unread]
                • Jameson Graef Rollins—[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Jameson Graef Rollins—[PATCH 8/8] emacs: eliminate show-tag-message in favor of just show-tag [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
                    • Jameson Graef Rollins—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, signed, unread]
                      • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
                  • Mark Walters—Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface [inbox, unread]
              • Mark Walters—Re: [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, unread]
                • Jameson Graef Rollins—Re: [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface [inbox, signed, unread]
        • Mark Walters—Re: [PATCH 2/8] emacs: update tag-completion function [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH 2/8] emacs: update tag-completion function [inbox, signed, unread]
    • Jameson Graef Rollins—emacs tagging cleanup, v3 [inbox, unread]
      • Jameson Graef Rollins—[PATCH 1/5] emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el [inbox, notmuch::patch, notmuch::pushed, unread]
        • Jameson Graef Rollins—[PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 3/5] emacs: modify search tag functions to use new notmuch-tag interface [inbox, notmuch::patch, notmuch::pushed, unread]
            • Jameson Graef Rollins—[PATCH 4/5] emacs: modify show tag functions to use new notmuch-tag interface [inbox, notmuch::patch, notmuch::pushed, unread]
              • Jameson Graef Rollins—[PATCH 5/5] emacs: eliminate search-tag-thread in favor of just search-tag [inbox, notmuch::patch, notmuch::pushed, unread]
          • Mark Walters—Re: [PATCH 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—[PATCH v2 2/5] emacs: allow notmuch-tag to accept string inputs and prompt for tags [inbox, notmuch::patch, notmuch::pushed, unread]
      • Tomi Ollila—Re: emacs tagging cleanup, v3 [inbox, notmuch::review, unread]