From: David Bremner <david@tethera.net>
To: Michael J Gruber <michaeljgruber+grubix+git@gmail.com>, notmuch@notmuchmail.org
Subject: Re: T450 fails with emacs 31
In-Reply-To: <CAA19uiRs8PnDoFrs7bdG=tXbXREcAw6C_A2oWzbRu4W2SQVRYg@mail.gmail.com>
References: <CAA19uiRs8PnDoFrs7bdG=tXbXREcAw6C_A2oWzbRu4W2SQVRYg@mail.gmail.com>
Date: Sat, 22 Aug 2026 21:24:04 -0300
Message-ID: <87cxv9fzvf.fsf@tethera.net>
MIME-Version: 1.0
Message-ID-Hash: NQUN3WNADFWR6NEYA6FBCSIUONC5OEJ5
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Michael J Gruber <michaeljgruber+grubix+git@gmail.com> writes:

> Hi there
>
> T450 fails with emacs 31 (which is in Fedora rawhide since yesterday
> or so). I have no idea what this test does and whether old or new
> behaviour (on cid:xxx) are incorrect or just different, but here's the

I verified this failure happens with emacs master (32.0.50).

As far as I currently understand

   - notmuch-show calls goto-address-fontify-region
   - the behaviour of goto-address-fontify-region changed (I guess
     around 31.0) to add a button instead of just an overlay

   - the (kindof hacky) implementation of
   #'notmuch-show-buttonise-links strips the overlays but not the
   button

   - the test function #'notmuch-test-mark-links checks for buttons.

I guess the simplest fix is probably to modify
#'notmuch-show-buttonise-links to delete the buttons added by
goto-address-fontify-region, but it feels a bit like piling hacks on
hacks.

In any case it is probably fine to skip that test with emacs 31, I don't
think there is a real user-impacting bug here.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org