From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, inwit <inwit@sindominio.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] test: add tests for --profile CLI option
In-Reply-To: <874iguduig.fsf@tethera.net>
References: <20260509155257.2477368-1-inwit@sindominio.net>
 <20260509155257.2477368-4-inwit@sindominio.net>
 <874iguduig.fsf@tethera.net>
User-Agent: Notmuch/0.40+24~gc45207d (https://notmuchmail.org) Emacs/27.1
Date: Mon, 17 Aug 2026 00:05:06 +0300
Message-ID: <y0y7ofi.u36o58-too@iki.fi>
MIME-Version: 1.0
Message-ID-Hash: NCYSXHMC2FCGSNO6PW7QAGGVICBHAH2Z
CC: inwit <inwit@sindominio.net>
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Sun, Aug 16 2026, David Bremner wrote:

> inwit <inwit@sindominio.net> writes:
>>  
>> +xdg_config_cli () {
>> +    local dir
>> +    local profile=${1:-default}
>> +    backup_config
>> +    dir="${HOME}/.config/notmuch/${profile}"
>> +    rm -rf $dir
> I wonder if we should have " " around $dir here?
> Basically if $HOME has spaces, the whole build will blow up, but maybe
> extra caution for rm -rf is suitable.

Definitely "$dir" (HOME seldom has spaces (nor $1)). At least it is
good for example.

... but, dir=${HOME}/.config/notmuch/${profile} would have worked
(I am not suggesting to change that, though :D)

Tomi

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org