From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dick Marinus <dick@mrns.nl>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] CLI/reply: use static const for reply_to_map
In-Reply-To: <20260623184003.4144137-2-dick@mrns.nl>
References: <20260623184003.4144137-1-dick@mrns.nl>
 <20260623184003.4144137-2-dick@mrns.nl>
User-Agent: Notmuch/0.40+24~gc45207d (https://notmuchmail.org) Emacs/27.1
Date: Thu, 25 Jun 2026 08:36:08 +0300
Message-ID: <y128riq.11coeh-too@iki.fi>
MIME-Version: 1.0
Message-ID-Hash: THAMDBIVGNUQ5X44WM3NPDMHFTRBQUOL
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Tue, Jun 23 2026, Dick Marinus wrote:

> Makes the structure compile-time constant and often stored in
> read-only location.
>
> Workaround to a problem with GCC (bugzilla #125252) which causes
> a segmentation fault.

This change looks good and commit message looks tolerable to me,

Tomi

> ---
>  notmuch-reply.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index 44297251d..c72ca227e 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -329,7 +329,7 @@ add_recipients_from_message (GMimeMessage *reply,
>  			     GMimeMessage *message,
>  			     bool reply_all)
>  {
> -    struct {
> +    static const struct {
>  	InternetAddressList * (*get_header)(GMimeMessage *message);
>  	GMimeAddressType recipient_type;
>      } reply_to_map[] = {
> -- 
> 2.54.0
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org