From: David Bremner <david@tethera.net>
To: Anton Khirnov <anton@khirnov.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 2/6] index: implement filtering attachments with an
 external program
In-Reply-To: <20260307160342.16482-3-anton@khirnov.net>
References: <20260307160342.16482-1-anton@khirnov.net>
 <20260307160342.16482-3-anton@khirnov.net>
Date: Sat, 04 Apr 2026 16:07:59 +0900
Message-ID: <878qb39p9s.fsf@tethera.net>
MIME-Version: 1.0
Message-ID-Hash: A2PY4M4WXPS3YD6SZTLGTZIHNJFXKKR2
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Anton Khirnov <anton@khirnov.net> writes:

> +
> +	flags |= O_NONBLOCK;
> +	ret = fcntl (pipes[i], F_SETFL, flags);
> +	if (ret == -1) {
> +	    _notmuch_database_log (db, "Error making the pipe non-blocking: %s\n",
> +				   strerror (errno));
> +	    goto CLOSE;
> +	}
> +    }
> +
> +    _filter_attachment_communicate (&pipes[0], &pipes[1],
> +				    &data, &data_len, db);

I hesitate to mention it, but I think this could reasonably be one line.

I was also annoyed by

>      body = (char *) g_byte_array_free (byte_array, false);
>  

But I realized I probably wrote it ;).

d

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org